On Feb 25, 2021, at 1:58 PM, David Howells [off-list ref] wrote:
Here's my take on v5 of Eric Snowberg's patches[1]:
This series of patches adds support for EFI_CERT_X509_GUID entries [2]. It has
been expanded to not only include dbx entries but also entries in the mokx.
Additionally Eric included his patches to preload these certificate [3].
The patches can be found on the following branch:
https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/log/?h=keys-cve-2020-26541-branch
Changes:
- I've modified the first patch in the series to fix a configuration
problem[4][5], to move the added functions to a more logical place within the
file and to add kerneldoc comments.
Thanks for making these changes. I reviewed and tested the series again. The only
thing I found is we may want to fold in this patch [1] too. Other than that,
everything LGTM.
[1] https://patchwork.kernel.org/project/keyrings/patch/20210204033208.1389901-1-eric.snowberg@oracle.com/
Link: https://lore.kernel.org/r/20210122181054.32635-1-eric.snowberg@oracle.com (local) [1]
Link: https://patchwork.kernel.org/project/linux-security-module/patch/20200916004927.64276-1-eric.snowberg@oracle.com/ [2]
Link: https://lore.kernel.org/patchwork/cover/1315485/ [3]
Link: https://lore.kernel.org/r/bc2c24e3-ed68-2521-0bf4-a1f6be4a895d@infradead.org/ (local) [4]
Link: https://lore.kernel.org/r/20210225125638.1841436-1-arnd@kernel.org/ (local) [5]
David
---
Eric Snowberg (4):
certs: Add EFI_CERT_X509_GUID support for dbx entries
certs: Move load_system_certificate_list to a common function
certs: Add ability to preload revocation certs
integrity: Load mokx variables into the blacklist keyring
certs/Kconfig | 8 +++
certs/Makefile | 20 ++++++-
certs/blacklist.c | 17 ++++++
certs/common.c | 56 +++++++++++++++++++
certs/common.h | 9 +++
certs/revocation_certificates.S | 21 +++++++
certs/system_keyring.c | 49 +---------------
scripts/Makefile | 1 +
security/integrity/platform_certs/load_uefi.c | 20 ++++++-
9 files changed, 150 insertions(+), 51 deletions(-)
create mode 100644 certs/common.c
create mode 100644 certs/common.h
create mode 100644 certs/revocation_certificates.S