Re: [PATCH v5 0/5] Enable root to update the blacklist keyring

On Thu, 2021-01-28 at 20:17 +0100, Mickaël Salaün wrote:

This fifth patch series is a rebase on David Howells's keys-misc branch.
The fix patches are already in this branch and then removed from this
series, other patches are unchanged.

The goal of these patches is to add a new configuration option to enable the
root user to load signed keys in the blacklist keyring.  This keyring is useful
to "untrust" certificates or files.  Enabling to safely update this keyring
without recompiling the kernel makes it more usable.

Previous patch series:
https://lore.kernel.org/lkml/20210121155513.539519-1-mic@digikod.net/ (local)

Regards,

Mickaël Salaün (5):
  tools/certs: Add print-cert-tbs-hash.sh
  certs: Check that builtin blacklist hashes are valid
  certs: Make blacklist_vet_description() more strict
  certs: Factor out the blacklist hash creation
  certs: Allow root user to append signed hashes to the blacklist
    keyring

 MAINTAINERS                                   |   2 +
 certs/.gitignore                              |   1 +
 certs/Kconfig                                 |  17 +-
 certs/Makefile                                |  15 +-
 certs/blacklist.c                             | 207 ++++++++++++++----
 crypto/asymmetric_keys/x509_public_key.c      |   3 +-
 include/keys/system_keyring.h                 |  14 +-
 scripts/check-blacklist-hashes.awk            |  37 ++++
 .../platform_certs/keyring_handler.c          |  26 +--
 tools/certs/print-cert-tbs-hash.sh            |  91 ++++++++
 10 files changed, 336 insertions(+), 77 deletions(-)
 create mode 100755 scripts/check-blacklist-hashes.awk
 create mode 100755 tools/certs/print-cert-tbs-hash.sh


base-commit: 8f0bfc25c907f38e7f9dc498e8f43000d77327ef

I tested these, so you both reviewed-by and tested-by
from side to all.

/Jarkko