Re: [PATCH v2] evm: Fix memory leak in init_desc
From: Mimi Zohar <zohar@linux.ibm.com>
Date: 2021-01-11 13:47:50
Also in:
kernel-janitors, linux-integrity, lkml
From: Mimi Zohar <zohar@linux.ibm.com>
Date: 2021-01-11 13:47:50
Also in:
kernel-janitors, linux-integrity, lkml
Hi Dinghao, On Sun, 2021-01-10 at 11:50 +0100, Markus Elfring wrote:
quoted
When kmalloc() fails, tmp_tfm allocated by crypto_alloc_shash() has not been freed, which leads to memleak.
In the future, please conform to Documentation/process/submitting-
patches.rst:
- The body of the explanation, line wrapped at 75 columns, which will
be copied to the permanent changelog to describe this patch.
Do any Linux developers care for the following aspects? * Imperative wordings for change descriptions https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=2ff90100ace886895e4fbb2850b8d5e49d931ed6#n89 * Usage of the term “memory leak” (instead of an abbreviation)
In general I agree, but this is a really small, obvious bug fix. Assuming Dinghao is fine with my updating the patch description, I'll fix it. Mimi