On 2021-01-08 20:55, Miguel Ojeda wrote:

On Fri, Jan 8, 2021 at 10:52 AM Preeti Nagar [off-list ref] 
wrote:

quoted

We want to seek your suggestions and comments on the idea and the 
changes
in the patch.

Not sure why I was Cc'd, but I have a quick comment nevertheless.

quoted

+#ifdef CONFIG_SECURITY_RTIC
+struct selinux_state selinux_state __rticdata;
+#else
 struct selinux_state selinux_state;
+#endif

If you define an empty __rticdata for the !CONFIG case, then we don't
need #ifdefs for uses like this.

Cheers,
Miguel

Thank you for the review! Will update this change in the next version of 
the patch soon.

Thanks,
Preeti