Re: [PATCH 000/141] Fix fall-through warnings for Clang
From: James Bottomley <James.Bottomley@HansenPartnership.com>
Date: 2020-11-22 19:54:23
Also in:
alsa-devel, amd-gfx, bridge, ceph-devel, dm-devel, dri-devel, intel-gfx, intel-wired-lan, keyrings, linux-acpi, linux-arm-msm, linux-block, linux-can, linux-cifs, linux-crypto, linux-ext4, linux-fbdev, linux-gpio, linux-hardening, linux-hwmon, linux-i3c, linux-ide, linux-iio, linux-input, linux-integrity, linux-media, linux-mediatek, linux-mm, linux-mmc, linux-nfs, linux-rdma, linux-renesas-soc, linux-scsi, linux-sctp, linux-usb, linux-watchdog, linux-wireless, lkml, netdev, netfilter-devel, op-tee, selinux, target-devel, xen-devel
On Sun, 2020-11-22 at 11:22 -0800, Joe Perches wrote:
On Sun, 2020-11-22 at 11:12 -0800, James Bottomley wrote:quoted
On Sun, 2020-11-22 at 10:25 -0800, Joe Perches wrote:quoted
On Sun, 2020-11-22 at 10:21 -0800, James Bottomley wrote:quoted
Please tell me our reward for all this effort isn't a single missing error print.There were quite literally dozens of logical defects found by the fallthrough additions. Very few were logging only.So can you give us the best examples (or indeed all of them if someone is keeping score)? hopefully this isn't a US election situation ...Gustavo? Are you running for congress now? https://lwn.net/Articles/794944/
That's 21 reported fixes of which about 50% seem to produce no change in code behaviour at all, a quarter seem to have no user visible effect with the remaining quarter producing unexpected errors on obscure configuration parameters, which is why no-one really noticed them before. James