Re: [PATCH 5/9] fs: remove various compat readv/writev helpers

From
Al Viro <viro@zeniv.linux.org.uk>
Date
2020-09-23 14:26:06
Also in
io-uring, keyrings, linux-arch, linux-arm-kernel, linux-block, linux-fsdevel, linux-mips, linux-mm, linux-s390, linux-scsi, linuxppc-dev, lkml, netdev, sparclinux
Reply to
Christoph Hellwig, 2020-09-23
On Wed, Sep 23, 2020 at 08:05:43AM +0200, Christoph Hellwig wrote:
quoted hunk ↗ jump to hunk
 COMPAT_SYSCALL_DEFINE3(readv, compat_ulong_t, fd,
-		const struct compat_iovec __user *,vec,
+		const struct iovec __user *, vec,
Um...  Will it even compile?
quoted hunk ↗ jump to hunk
 #ifdef __ARCH_WANT_COMPAT_SYS_PREADV64
 COMPAT_SYSCALL_DEFINE4(preadv64, unsigned long, fd,
-		const struct compat_iovec __user *,vec,
+		const struct iovec __user *, vec,
Ditto.  Look into include/linux/compat.h and you'll see

asmlinkage long compat_sys_preadv64(unsigned long fd,
                const struct compat_iovec __user *vec,
                unsigned long vlen, loff_t pos);

How does that manage to avoid the compiler screaming bloody
murder?
Thread (25 messages) 25 messages, 5 authors, last reply 2020-09-23
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help