Thread (28 messages) 28 messages, 5 authors, 2020-08-07

Re: [PATCH v4 07/17] fs/kernel_read_file: Switch buffer size arg to size_t

From: James Morris <jmorris@namei.org>
Date: 2020-07-30 02:25:35
Also in: linux-efi, linux-integrity, linux-kselftest, lkml, selinux

On Wed, 29 Jul 2020, Kees Cook wrote:
In preparation for further refactoring of kernel_read_file*(), rename
the "max_size" argument to the more accurate "buf_size", and correct
its type to size_t. Add kerndoc to explain the specifics of how the
arguments will be used. Note that with buf_size now size_t, it can no
longer be negative (and was never called with a negative value). Adjust
callers to use it as a "maximum size" when *buf is NULL.

Acked-by: Scott Branden <scott.branden@broadcom.com>
Reviewed-by: Mimi Zohar <zohar@linux.ibm.com>
Reviewed-by: Luis Chamberlain <mcgrof@kernel.org>
Signed-off-by: Kees Cook <redacted>

Reviewed-by: James Morris <redacted>


-- 
James Morris
[off-list ref]
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help