Re: [PATCH] crypto: af_alg - Fix regression on empty requests
flat view
From: Naresh Kamboju <hidden>
Date: 2020-06-30 08:48:29
Also in:
keyrings, linux-crypto, linux-next, linuxppc-dev, lkml, ltp, stable
On Fri, 26 Jun 2020 at 12:00, Herbert Xu [off-list ref] wrote:
On Tue, Jun 23, 2020 at 10:02:17AM -0700, Eric Biggers wrote:quoted
The source code for the two failing AF_ALG tests is here: https://github.com/linux-test-project/ltp/blob/master/testcases/kernel/crypto/af_alg02.c https://github.com/linux-test-project/ltp/blob/master/testcases/kernel/crypto/af_alg05.c They use read() and write(), not send() and recv(). af_alg02 uses read() to read from a "salsa20" request socket without writing anything to it. It is expected that this returns 0, i.e. that behaves like encrypting an empty message.
Since we are on this subject, LTP af_alg02 test case fails on stable 4.9 and stable 4.4 This is not a regression because the test case has been failing from the beginning. Is this test case expected to fail on stable 4.9 and 4.4 ? or any chance to fix this on these older branches ? Test output: af_alg02.c:52: BROK: Timed out while reading from request socket. ref: https://qa-reports.linaro.org/lkft/linux-stable-rc-4.9-oe/build/v4.9.228-191-g082e807235d7/testrun/2884917/suite/ltp-crypto-tests/test/af_alg02/history/ https://qa-reports.linaro.org/lkft/linux-stable-rc-4.9-oe/build/v4.9.228-191-g082e807235d7/testrun/2884606/suite/ltp-crypto-tests/test/af_alg02/log - Naresh