Thread (3 messages) flat view 3 messages, 2 authors, 2020-06-17

Re: [PATCH] fs: move kernel_read_file* to its own include file

From: Scott Branden <scott.branden@broadcom.com>
Date: 2020-06-17 06:04:55
Also in: kexec, linux-fsdevel, linux-integrity, lkml, selinux

Hi Greg,

On 2020-06-16 10:26 p.m., Greg Kroah-Hartman wrote:
On Tue, Jun 16, 2020 at 08:31:52PM -0700, Scott Branden wrote:
quoted
Move kernel_read_file* to it own kernel_read_file.h include file.
That says what you did, but not _why_ you are doing it :(
I have no real opinion as to where these functions end up.
I simply wish to add kernel_pread_file* support and current comment is 
the existing kernel_read_file* functions
are in linux/fs.h and I shouldn't add more to that file.

I'd be quite happy to leave them in linux/fs.h if that is desired as well.

I can update the commit according to Christoph's comment:

"Can you also move kernel_read_* out of fs.h?  That header gets pulled
in just about everywhere and doesn't really need function not related
to the general fs interface."





Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help