On Wed, 20 May 2020, Alexei Starovoitov wrote:

On Wed, May 20, 2020 at 8:15 AM Casey Schaufler [off-list ref] wrote:

quoted

On 5/20/2020 5:56 AM, KP Singh wrote:

quoted

From: KP Singh <redacted>

secid_to_secctx is not stackable, and since the BPF LSM registers this
hook by default, the call_int_hook logic is not suitable which
"bails-on-fail" and casues issues when other LSMs register this hook and
eventually breaks Audit.

In order to fix this, directly iterate over the security hooks instead
of using call_int_hook as suggested in:

https: //lore.kernel.org/bpf/9d0eb6c6-803a-ff3a-5603-9ad6d9edfc00@schaufler-ca.com/#t

Fixes: 98e828a0650f ("security: Refactor declaration of LSM hooks")
Fixes: 625236ba3832 ("security: Fix the default value of secid_to_secctx hook"
Reported-by: Alexei Starovoitov <ast@kernel.org>
Signed-off-by: KP Singh <redacted>

This looks fine.

Tested. audit works now.
I fixed missing ')' in the commit log
and applied to bpf tree.
It will be on the way to Linus tree soon.

Please add:


Acked-by: James Morris <redacted>


-- 
James Morris
[off-list ref]