Thread (5 messages) 5 messages, 3 authors, 2020-03-05

Re: [PATCH bpf-next] bpf: Fix bpf_prog_test_run_tracing for !CONFIG_NET

flat view

From: Alexei Starovoitov <hidden>
Date: 2020-03-05 23:16:42
Also in: bpf, linux-next

On Thu, Mar 5, 2020 at 3:12 PM Randy Dunlap [off-list ref] wrote:
On 3/5/20 2:01 PM, KP Singh wrote:
quoted
From: KP Singh <redacted>

test_run.o is not built when CONFIG_NET is not set and
bpf_prog_test_run_tracing being referenced in bpf_trace.o causes the
linker error:

ld: kernel/trace/bpf_trace.o:(.rodata+0x38): undefined reference to
 `bpf_prog_test_run_tracing'

Add a __weak function in bpf_trace.c to handle this.

Fixes: da00d2f117a0 ("bpf: Add test ops for BPF_PROG_TYPE_TRACING")
Signed-off-by: KP Singh <redacted>
Reported-by: Randy Dunlap <rdunlap@infradead.org>
Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested
Since it was at the top of the tree I amended the commit
with your tags.
Thanks for reporting and testing.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help