Thread (18 messages) 18 messages, 2 authors, 2020-03-04

Re: [PATCH bpf-next v2 4/7] bpf: Attachment verification for BPF_MODIFY_RETURN

From: Andrii Nakryiko <hidden>
Date: 2020-03-04 05:13:11
Also in: bpf, lkml

On Tue, Mar 3, 2020 at 5:56 PM KP Singh [off-list ref] wrote:
From: KP Singh <redacted>

- Allow BPF_MODIFY_RETURN attachment only to functions that are:

    * Whitelisted by for error injection i.e. by checking
      within_error_injection_list. Similar disucssions happened for the
      bpf_overrie_return helper.
2 typos: discussions and bpf_override_return ;)
    * security hooks, this is expected to be cleaned up with the LSM
      changes after the KRSI patches introduce the LSM_HOOK macro:

        https://lore.kernel.org/bpf/20200220175250.10795-1-kpsingh@chromium.org/ (local)

- The attachment is currently limited to functions that return an int.
  This can be extended later other types (e.g. PTR).

Signed-off-by: KP Singh <redacted>
---
Acked-by: Andrii Nakryiko <redacted>
 kernel/bpf/btf.c      | 28 ++++++++++++++++++++--------
 kernel/bpf/verifier.c | 31 +++++++++++++++++++++++++++++++
 2 files changed, 51 insertions(+), 8 deletions(-)
[...]
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help