Re: [PATCH v8 05/11] proc: add helpers to set and get proc hidepid and gid... | linux-security-module

[PATCH v8 00/11] proc: modernize proc to support multiple private instances · Alexey Gladkov <hidden> · 2020-02-10
[PATCH v8 02/11] proc: add proc_fs_info struct to store proc information · Alexey Gladkov <hidden> · 2020-02-10
[PATCH v8 03/11] proc: move /proc/{self|thread-self} dentries to proc_fs_info · Alexey Gladkov <hidden> · 2020-02-10
Re: [PATCH v8 03/11] proc: move /proc/{self|thread-self} dentries to proc_fs_info · Andy Lutomirski <luto@kernel.org> · 2020-02-10
Re: [PATCH v8 03/11] proc: move /proc/{self|thread-self} dentries to proc_fs_info · Alexey Gladkov <hidden> · 2020-02-12
[PATCH v8 07/11] proc: flush task dcache entries from all procfs instances · Alexey Gladkov <hidden> · 2020-02-10
Re: [PATCH v8 07/11] proc: flush task dcache entries from all procfs instances · Linus Torvalds <torvalds@linux-foundation.org> · 2020-02-10
Re: [PATCH v8 07/11] proc: flush task dcache entries from all procfs instances · Al Viro <viro@zeniv.linux.org.uk> · 2020-02-10
Re: [PATCH v8 07/11] proc: flush task dcache entries from all procfs instances · Al Viro <viro@zeniv.linux.org.uk> · 2020-02-11
Re: [PATCH v8 07/11] proc: flush task dcache entries from all procfs instances · Alexey Gladkov <hidden> · 2020-02-12
[PATCH v8 10/11] docs: proc: add documentation for "hidepid=4" and "subset=pidfs" options and new mount behavior · Alexey Gladkov <hidden> · 2020-02-10
Re: [PATCH v8 10/11] docs: proc: add documentation for "hidepid=4" and "subset=pidfs" options and new mount behavior · Andy Lutomirski <luto@kernel.org> · 2020-02-10
Re: [PATCH v8 10/11] docs: proc: add documentation for "hidepid=4" and "subset=pidfs" options and new mount behavior · Alexey Gladkov <hidden> · 2020-02-12
[PATCH v8 11/11] proc: Move hidepid values to uapi as they are user interface to mount · Alexey Gladkov <hidden> · 2020-02-10
[PATCH v8 09/11] proc: add option to mount only a pids subset · Alexey Gladkov <hidden> · 2020-02-10
[PATCH v8 08/11] proc: instantiate only pids that we can ptrace on 'hidepid=4' mount option · Alexey Gladkov <hidden> · 2020-02-10
Re: [PATCH v8 08/11] proc: instantiate only pids that we can ptrace on 'hidepid=4' mount option · Jordan Glover <hidden> · 2020-02-10
Re: [PATCH v8 08/11] proc: instantiate only pids that we can ptrace on 'hidepid=4' mount option · Alexey Gladkov <hidden> · 2020-02-12
[PATCH v8 05/11] proc: add helpers to set and get proc hidepid and gid mount options · Alexey Gladkov <hidden> · 2020-02-10
Re: [PATCH v8 05/11] proc: add helpers to set and get proc hidepid and gid mount options · Andy Lutomirski <luto@kernel.org> · 2020-02-10
Re: [PATCH v8 05/11] proc: add helpers to set and get proc hidepid and gid mount options · Alexey Gladkov <hidden> · 2020-02-12
[PATCH v8 06/11] proc: support mounting procfs instances inside same pid namespace · Alexey Gladkov <hidden> · 2020-02-10
[PATCH v8 04/11] proc: move hide_pid, pid_gid from pid_namespace to proc_fs_info · Alexey Gladkov <hidden> · 2020-02-10
[PATCH v8 01/11] proc: Rename struct proc_fs_info to proc_fs_opts · Alexey Gladkov <hidden> · 2020-02-10

Re: [PATCH v8 05/11] proc: add helpers to set and get proc hidepid and gid mount options

From: Andy Lutomirski <luto@kernel.org>
Date: 2020-02-10 18:31:03
Also in: linux-api, linux-fsdevel, lkml

On Mon, Feb 10, 2020 at 7:06 AM Alexey Gladkov [off-list ref] wrote:

This is a cleaning patch to add helpers to set and get proc mount
options instead of directly using them. This make it easy to track
what's happening and easy to update in future.

On a cursory inspection, this looks like it obfuscates the code, and I
don't see where it does something useful later in the series.  What is
this abstraction for?

--Andy

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help