Thread (18 messages) 18 messages, 6 authors, 2020-01-10

Re: [PATCH 1/2] selinux: treat atomic flags more carefully

From: Paul Moore <paul@paul-moore.com>
Date: 2020-01-10 20:23:12
Also in: selinux

On Tue, Jan 7, 2020 at 2:46 PM James Morris [off-list ref] wrote:
On Tue, 7 Jan 2020, Ondrej Mosnacek wrote:
quoted
The disabled/enforcing/initialized flags are all accessed concurrently
by threads so use the appropriate accessors that ensure atomicity and
document that it is expected.

Use smp_load/acquire...() helpers (with memory barriers) for the
initialized flag, since it gates access to the rest of the state
structures.

Note that the disabled flag is currently not used for anything other
than avoiding double disable, but it will be used for bailing out of
hooks once security_delete_hooks() is removed.

Signed-off-by: Ondrej Mosnacek <omosnace@redhat.com>

Reviewed-by: James Morris <redacted>
You get an extra helping of gratitude James for being the only one to
properly trim your reply ;)

-- 
paul moore
www.paul-moore.com
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help