Re: [PATCH] tpm_tis: Move setting of TPM_CHIP_FLAG_IRQ into tpm_tis_probe_irq_single

[ add Jerry ]

On Wed, Nov 27, 2019 at 1:11 PM Jarkko Sakkinen
[off-list ref] wrote:

On Thu, Nov 21, 2019 at 11:49:49AM -0700, Jerry Snitselaar wrote:

quoted

On Sat Nov 16 19, Stefan Berger wrote:

quoted

On 11/14/19 11:44 AM, Jarkko Sakkinen wrote:

quoted

On Thu, Nov 14, 2019 at 06:41:51PM +0200, Jarkko Sakkinen wrote:

quoted

On Tue, Nov 12, 2019 at 03:27:25PM -0500, Stefan Berger wrote:

quoted

From: Stefan Berger <stefanb@linux.ibm.com>

Move the setting of the TPM_CHIP_FLAG_IRQ for irq probing into
tpm_tis_probe_irq_single before calling tpm_tis_gen_interrupt.
This move handles error conditions better that may arise if anything
before fails in tpm_tis_probe_irq_single.

Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
Suggested-by: Jerry Snitselaar <redacted>

What about just changing the condition?

Also cannot take this since it is not a bug (no fixes tag).

I'll repost but will wait until Jerry has tested it on that machine.

   Stefan

quoted

/Jarkko

It appears they still have the problem. I'm still waiting on logistics
to send me a system to debug.

Which hardware is guaranteed to ignite this? I can try to get test hw
for this from somewhere. Kind of looking into this blinded ATM. Dan?

Jerry had mentioned that this was also occurring on T490s. Otherwise
I'll ping you offline about the system I saw this on internally.