Thread (52 messages) 52 messages, 11 authors, 2019-12-08

Re: [RFC PATCH 07/10] pipe: Conditionalise wakeup in pipe_read() [ver #2]

From: David Howells <dhowells@redhat.com>
Date: 2019-10-31 15:21:32
Also in: keyrings, linux-api, linux-block, linux-fsdevel, linux-usb, lkml

Konstantin Khlebnikov [off-list ref] wrote:
quoted
Only do a wakeup in pipe_read() if we made space in a completely full
buffer.  The producer shouldn't be waiting on pipe->wait otherwise.
We could go further and wakeup writer only when at least half of buffer is
empty.  This gives better batching and reduces rate of context switches.

https://lore.kernel.org/lkml/157219118016.7078.16223055699799396042.stgit@buzz/T/#u (local)
Yeah, I saw that.  I suspect that where you put the slider may depend on the
context.

David
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help