[PATCH] genetlink: prevent memory leak in netlbl_unlabel_defconf
STALE2561d
From: Navid Emamdoost <hidden>
Date: 2019-09-25 22:10:21
Also in:
lkml, netdev
Subsystem:
networking [general], networking [labeled] (netlabel, labeled ipsec, secmark), the rest · Maintainers:
"David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Paul Moore, Linus Torvalds
In netlbl_unlabel_defconf if netlbl_domhsh_add_default fails the allocated entry should be released. Signed-off-by: Navid Emamdoost <redacted> --- net/netlabel/netlabel_unlabeled.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/net/netlabel/netlabel_unlabeled.c b/net/netlabel/netlabel_unlabeled.c
index d2e4ab8d1cb1..c63ec480ee4e 100644
--- a/net/netlabel/netlabel_unlabeled.c
+++ b/net/netlabel/netlabel_unlabeled.c@@ -1541,8 +1541,10 @@ int __init netlbl_unlabel_defconf(void) entry->family = AF_UNSPEC; entry->def.type = NETLBL_NLTYPE_UNLABELED; ret_val = netlbl_domhsh_add_default(entry, &audit_info); - if (ret_val != 0) + if (ret_val != 0) { + kfree(entry); return ret_val; + } netlbl_unlabel_acceptflg_set(1, &audit_info);
--
2.17.1