Thread (5 messages) 5 messages, 4 authors, 2019-09-01

Re: [PATCH] netlabel: remove redundant assignment to pointer iter

flat view

From: Paul Moore <paul@paul-moore.com>
Date: 2019-09-01 18:23:28
Also in: kernel-janitors, lkml, netdev

On Sun, Sep 1, 2019 at 11:52 AM Colin King [off-list ref] wrote:
From: Colin Ian King <redacted>

Pointer iter is being initialized with a value that is never read and
is being re-assigned a little later on. The assignment is redundant
and hence can be removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <redacted>
---
 net/netlabel/netlabel_kapi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Acked-by: Paul Moore <paul@paul-moore.com>
quoted hunk ↗ jump to hunk
diff --git a/net/netlabel/netlabel_kapi.c b/net/netlabel/netlabel_kapi.c
index 2b0ef55cf89e..409a3ae47ce2 100644
--- a/net/netlabel/netlabel_kapi.c
+++ b/net/netlabel/netlabel_kapi.c
@@ -607,7 +607,7 @@ static struct netlbl_lsm_catmap *_netlbl_catmap_getnode(
  */
 int netlbl_catmap_walk(struct netlbl_lsm_catmap *catmap, u32 offset)
 {
-       struct netlbl_lsm_catmap *iter = catmap;
+       struct netlbl_lsm_catmap *iter;
        u32 idx;
        u32 bit;
        NETLBL_CATMAP_MAPTYPE bitmap;
--
2.20.1
-- 
paul moore
www.paul-moore.com
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help