Re: [PATCH] tpm_tis: Fix interrupt probing
From: Jarkko Sakkinen <hidden>
Date: 2019-08-30 17:00:11
Also in:
linux-integrity, lkml
On Thu, Aug 29, 2019 at 08:11:27PM -0400, Stefan Berger wrote:
On 8/29/19 12:10 PM, Jarkko Sakkinen wrote:quoted
On Thu, Aug 29, 2019 at 04:20:21PM +0300, Jarkko Sakkinen wrote:quoted
On Tue, Aug 27, 2019 at 03:34:36PM -0400, Stefan Berger wrote:quoted
On 8/27/19 11:19 AM, Jarkko Sakkinen wrote:quoted
On Tue, Aug 27, 2019 at 04:14:00PM +0300, Jarkko Sakkinen wrote:quoted
On Tue, Aug 20, 2019 at 08:25:17AM -0400, Stefan Berger wrote:quoted
From: Stefan Berger <stefanb@linux.ibm.com> The interrupt probing of the TPM TIS was broken since we are trying to run it without an active locality and without the TPM_CHIP_FLAG_IRQ set. Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>Need these: Cc: linux-stable@vger.kernel.org Fixes: a3fbfae82b4c ("tpm: take TPM chip power gating out of tpm_transmit()") Thank you. I'll apply this to my tree. Reviewed-by: Jarkko Sakkinen <redacted>The commit went in the following form: http://git.infradead.org/users/jjs/linux-tpmdd.git/commit/9b558deab2c5d7dc23d5f7a4064892ede482ad32I saw you dropped the stetting of the IRQ flag - I needed it, otherwise it wouldn't execute certain code paths.I explained why I removed that part. There was no any reasoning for it. Also, it cannot be in the same commit if it fixes a diffent issue.AFAIK they go with different fixes-tags.I sent a separate patch for this. It looks like this bug goes back to when the TPM_CHIP_FLAG_IRQ was introduced in March 2019?!
Thank you! Reviewed-by: Jarkko Sakkinen <redacted> /Jarkko