Re: [GIT PULL] SafeSetID LSM changes for 5.3
From: Linus Torvalds <torvalds@linux-foundation.org>
Date: 2019-07-16 19:14:21
Also in:
lkml
From: Linus Torvalds <torvalds@linux-foundation.org>
Date: 2019-07-16 19:14:21
Also in:
lkml
On Tue, Jul 16, 2019 at 12:06 PM Linus Torvalds [off-list ref] wrote:
- Please use the "git pull-request" format and then add any extra notes you feel are necessary Yes, your pull request is *almost* git pull-request, but you seem to have actively removed whitespace making it almost illegible. It's really hard to pick out the line that has the actual git repository address, because it's basically hidden inside one big blob of text.
Extra note on this: you seem to have done "git pull-request" in a wide
window, and then copied-and-pasted it into your MUA.
So the diffstat lines are also very long, and then they line-wrap and
it all looks nasty.
Avoid this by either using a file for the output (that you then edit
for your own added messages), or using a normal 80x25 terminal or
something.
I guess I should ask Junio to add a "--stat=80" to the upstream git
request-pull script.
Linus