Re: [PATCH v5 04/12] S.A.R.A.: generic DFA for string matching
From: Jann Horn <jannh@google.com>
Date: 2019-07-06 18:33:17
Also in:
linux-mm, lkml
On Sat, Jul 6, 2019 at 12:55 PM Salvatore Mesoraca [off-list ref] wrote:
Creation of a generic Discrete Finite Automata implementation for string matching. The transition tables have to be produced in user-space. This allows us to possibly support advanced string matching patterns like regular expressions, but they need to be supported by user-space tools.
AppArmor already has a DFA implementation that takes a DFA machine from userspace and runs it against file paths; see e.g. aa_dfa_match(). Did you look into whether you could move their DFA to some place like lib/ and reuse it instead of adding yet another generic rule interface to the kernel? [...]
quoted hunk ↗ jump to hunk
+++ b/security/sara/dfa.c@@ -0,0 +1,335 @@ +// SPDX-License-Identifier: GPL-2.0 + +/* + * S.A.R.A. Linux Security Module + * + * Copyright (C) 2017 Salvatore Mesoraca <s.mesoraca16@gmail.com> + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 2, as + * published by the Free Software Foundation.
Throughout the series, you are adding files that both add an SPDX identifier and have a description of the license in the comment block at the top. The SPDX identifier already identifies the license.