Re: [RFC PATCH] fanotify, inotify, dnotify, security: add security hook for fs notifications
From: Randy Dunlap <hidden>
Date: 2019-07-10 17:53:16
Also in:
linux-fsdevel, lkml, selinux
On 7/10/19 10:22 AM, Joe Perches wrote:
On Wed, 2019-07-10 at 10:18 -0700, Joe Perches wrote:quoted
On Wed, 2019-07-10 at 09:49 -0700, Randy Dunlap wrote:quoted
On 7/10/19 9:38 AM, Casey Schaufler wrote:quoted
On 7/10/2019 6:34 AM, Aaron Goidel wrote:quoted
@@ -3261,6 +3262,26 @@ static int selinux_inode_removexattr(struct dentry *dentry, const char *name) return -EACCES; } +static int selinux_inode_notify(struct inode *inode, u64 mask) +{ + u32 perm = FILE__WATCH; // basic permission, can a watch be set?We don't use // comments in the Linux kernel.I thought that we had recently moved into the 21st century on that issue, but I don't see it mentioned in coding-style.rst. Maybe we need a Doc update. checkpatch allows C99 comments by default. Joe, do you recall about this?My recollection is it was something I thought was just simple and useful so I added it to checkpatch without going through the negative of the nominal approvals required by modifying CodingStyle.https://lkml.org/lkml/2016/7/8/625
Aha, thanks, I don't recall seeing that one. -- ~Randy