Re: linux-next: Tree for Jun 26 (security/integrity/ima/)
From: David Howells <dhowells@redhat.com>
Date: 2019-06-27 13:29:15
Also in:
linux-integrity, linux-next, lkml
From: David Howells <dhowells@redhat.com>
Date: 2019-06-27 13:29:15
Also in:
linux-integrity, linux-next, lkml
Mimi Zohar [off-list ref] wrote:
quoted
CC security/integrity/ima/ima_fs.o In file included from ../security/integrity/ima/ima.h:25:0, from ../security/integrity/ima/ima_fs.c:26: ../security/integrity/ima/../integrity.h:170:18: warning: ‘struct key_acl’ declared inside parameter list [enabled by default] struct key_acl *acl) ^ ../security/integrity/ima/../integrity.h:170:18: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default]David, CONFIG_INTEGRITY_SIGNATURE is dependent on KEYS being enabled, but the stub functions are not. There's now a dependency on key_acl().
I added a forward declaration for struct key_acl into security/integrity/integrity.h as you can see here: https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/diff/security/integrity/integrity.h?h=keys-acl&id=75ce113a1d56880e5abd37fa664ea9af399d2bcd which might not have made it into linux-next before you used it. David