Thread (3 messages) 3 messages, 3 authors, 2019-06-17

Re: [PATCH] integrity: Fix __integrity_init_keyring() section mismatch

From: Nayna <hidden>
Date: 2019-06-17 14:05:05
Also in: lkml


On 06/17/2019 03:44 AM, Geert Uytterhoeven wrote:
With gcc-4.6.3:

     WARNING: vmlinux.o(.text.unlikely+0x24c64): Section mismatch in reference from the function __integrity_init_keyring() to the function .init.text:set_platform_trusted_keys()
     The function __integrity_init_keyring() references
     the function __init set_platform_trusted_keys().
     This is often because __integrity_init_keyring lacks a __init
     annotation or the annotation of set_platform_trusted_keys is wrong.

Indeed, if the compiler decides not to inline __integrity_init_keyring(),
a warning is issued.

Fix this by adding the missing __init annotation.

Fixes: 9dc92c45177ab70e ("integrity: Define a trusted platform keyring")
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Thanks for fixing it.

Reviewed-by: Nayna Jain <nayna@linux.ibm.com>

Thanks & Regards,
          - Nayna
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help