Re: [PATCH 1/7] keys: sparse: Fix key_fs[ug]id_changed()

[PATCH 0/7] keys: Miscellany · David Howells <dhowells@redhat.com> · 2019-05-22
[PATCH 1/7] keys: sparse: Fix key_fs[ug]id_changed() · David Howells <dhowells@redhat.com> · 2019-05-22
Re: [PATCH 1/7] keys: sparse: Fix key_fs[ug]id_changed() · James Morris <jmorris@namei.org> · 2019-05-24
[PATCH 2/7] keys: sparse: Fix incorrect RCU accesses · David Howells <dhowells@redhat.com> · 2019-05-22
Re: [PATCH 2/7] keys: sparse: Fix incorrect RCU accesses · James Morris <jmorris@namei.org> · 2019-05-25
[PATCH 3/7] keys: sparse: Fix kdoc mismatches · David Howells <dhowells@redhat.com> · 2019-05-22
Re: [PATCH 3/7] keys: sparse: Fix kdoc mismatches · James Morris <jmorris@namei.org> · 2019-05-25
[PATCH 4/7] keys: Break bits out of key_unlink() · David Howells <dhowells@redhat.com> · 2019-05-22
Re: [PATCH 4/7] keys: Break bits out of key_unlink() · James Morris <jmorris@namei.org> · 2019-05-28
[PATCH 5/7] keys: Make __key_link_begin() handle lockdep nesting · David Howells <dhowells@redhat.com> · 2019-05-22
Re: [PATCH 5/7] keys: Make __key_link_begin() handle lockdep nesting · James Morris <jmorris@namei.org> · 2019-05-28
[PATCH 6/7] keys: Add a keyctl to move a key between keyrings · David Howells <dhowells@redhat.com> · 2019-05-22
Re: [PATCH 6/7] keys: Add a keyctl to move a key between keyrings · James Morris <jmorris@namei.org> · 2019-05-28
Re: [PATCH 6/7] keys: Add a keyctl to move a key between keyrings · David Howells <dhowells@redhat.com> · 2019-05-29
Re: [PATCH 6/7] keys: Add a keyctl to move a key between keyrings · Eric Biggers <ebiggers@kernel.org> · 2019-05-29
Re: [PATCH 6/7] keys: Add a keyctl to move a key between keyrings · David Howells <dhowells@redhat.com> · 2019-05-30
[PATCH 7/7] keys: Grant Link permission to possessers of request_key auth keys · David Howells <dhowells@redhat.com> · 2019-05-22
Re: [PATCH 7/7] keys: Grant Link permission to possessers of request_key auth keys · James Morris <jmorris@namei.org> · 2019-05-28

From: James Morris <jmorris@namei.org>
Date: 2019-05-24 19:38:42
Also in: keyrings, lkml

On Wed, 22 May 2019, David Howells wrote:

Sparse warnings are incurred by key_fs[ug]id_changed() due to unprotected
accesses of tsk->cred, which is marked __rcu.

Fix this by passing the new cred struct to these functions from
commit_creds() rather than the task pointer.

Signed-off-by: David Howells <dhowells@redhat.com>


Reviewed-by: James Morris <redacted>


-- 
James Morris
[off-list ref]

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help