On Fri, 3 May 2019 at 08:15, joeyli [off-list ref] wrote:

On Thu, May 02, 2019 at 10:53:31AM +0200, Ard Biesheuvel wrote:

quoted

On Thu, 2 May 2019 at 06:04, Lee, Chun-Yi [off-list ref] wrote:

quoted

This function can be used to convert EFI status value to string
for printing out debug message. Using this function can improve
the readability of log.

v2.

Please move the changelog out of the commit log (move it below the ---
further down)

OK! I will moved the changelog out of the commit log.

quoted

quoted

- Changed the wording in subject and description.
- Moved the marco immediately after the status value definitions.
- Turned into a proper function instead of inline.

You missed my point here. A proper function means the function in a .c
file, and only the declaration in a .h file. This way, you are still
duplicating the literal strings into every object file that references
this function.

Sorry for I missunderstood. I will move the function to load_uefi.c.

No, please move it to a file that is shared between all EFI code.