[PATCH 09/58] LSM: Use lsm_export in the getpeersec_dgram hooks

STALE2679d

From: Casey Schaufler <casey@schaufler-ca.com>
Date: 2019-05-31 23:32:59
Also in: selinux
Subsystem: apparmor security module, security subsystem, selinux security module, smack security module, the rest · Maintainers: John Johansen, John Johansen, Georgia Garcia, Paul Moore, James Morris, "Serge E. Hallyn", Stephen Smalley, Casey Schaufler, Linus Torvalds

Revision v1 of 49 in this series.

Revisions (49)

2019-04-09 v1 [diff vs current]
2019-04-09 v1 [diff vs current]
2019-04-09 v1 [diff vs current]
2019-05-31 v1 [diff vs current]
2019-05-31 v1 current
2019-06-02 v1 [diff vs current]
2019-06-18 v2 [diff vs current]
2019-06-21 v3 [diff vs current]
2019-06-24 v3 [diff vs current]
2019-06-26 v4 [diff vs current]
2019-07-03 v5 [diff vs current]
2019-07-26 v5 [diff vs current]
2019-08-07 v7 [diff vs current]
2019-08-29 v8 [diff vs current]
2019-10-24 v10 [diff vs current]
2019-11-13 v10 [diff vs current]
2019-11-13 v11 [diff vs current]
2019-11-13 v11 [diff vs current]
2019-11-13 v11 [diff vs current]
2019-11-19 v11 [diff vs current]
2019-11-19 v11 [diff vs current]
2019-11-27 v11 [diff vs current]
2019-12-16 v12 [diff vs current]
2019-12-16 v12 [diff vs current]
2019-12-16 v12 [diff vs current]
2019-12-24 v12 [diff vs current]
2019-12-25 v13 [diff vs current]
2020-01-24 v14 [diff vs current]
2020-02-14 v15 [diff vs current]
2020-04-07 v16 [diff vs current]
2020-11-04 v22 [diff vs current]
2020-11-05 v22 [diff vs current]
2020-11-20 v22 [diff vs current]
2021-01-27 v24 [diff vs current]
2021-03-09 v25 [diff vs current]
2021-05-13 v26 [diff vs current]
2021-06-11 v27 [diff vs current]
2021-07-22 v28 [diff vs current]
2021-09-24 v29 [diff vs current]
2021-11-24 v30 [diff vs current]
2021-12-13 v31 [diff vs current]
2022-02-03 v32 [diff vs current]
2022-03-10 v33 [diff vs current]
2022-04-07 v34 [diff vs current]
2022-04-15 v34 [diff vs current]
2022-04-18 v35 [diff vs current]
2022-06-09 v36 [diff vs current]
2022-06-28 v37 [diff vs current]
2022-09-27 v38 [diff vs current]

Convert the getpeersec_dgram hooks to use the lsm_export
structure instead of a u32 secid. There is some scaffolding
involved that will be removed when security_getpeersec_dgram()
is updated.

Signed-off-by: Casey Schaufler <casey@schaufler-ca.com>
---
 include/linux/lsm_hooks.h  |  5 +++--
 security/apparmor/lsm.c    |  3 ++-
 security/security.c        | 13 ++++++++++---
 security/selinux/hooks.c   |  6 ++++--
 security/smack/smack_lsm.c |  5 +++--
 5 files changed, 22 insertions(+), 10 deletions(-)

diff --git a/include/linux/lsm_hooks.h b/include/linux/lsm_hooks.h
index 800040050032..bcc628cffe6a 100644
--- a/include/linux/lsm_hooks.h
+++ b/include/linux/lsm_hooks.h

@@ -881,7 +881,7 @@
  *	ancillary message type.
  *	@sock contains the peer socket. May be NULL.
  *	@skb is the sk_buff for the packet being queried. May be NULL.
- *	@secid pointer to store the secid of the packet.
+ *	@l is a pointer to a buffer in which to copy the security data
  *	Return 0 on success, error on failure.
  * @sk_alloc_security:
  *	Allocate and attach a security structure to the sk->sk_security field,

@@ -1702,7 +1702,8 @@ union security_list_options {
 					char __user *optval,
 					int __user *optlen, unsigned len);
 	int (*socket_getpeersec_dgram)(struct socket *sock,
-					struct sk_buff *skb, u32 *secid);
+					struct sk_buff *skb,
+					struct lsm_export *l);
 	int (*sk_alloc_security)(struct sock *sk, int family, gfp_t priority);
 	void (*sk_free_security)(struct sock *sk);
 	void (*sk_clone_security)(const struct sock *sk, struct sock *newsk);

diff --git a/security/apparmor/lsm.c b/security/apparmor/lsm.c
index 706e5ae09170..24b638bd4305 100644
--- a/security/apparmor/lsm.c
+++ b/security/apparmor/lsm.c

@@ -1096,7 +1096,8 @@ static int apparmor_socket_getpeersec_stream(struct socket *sock,
  * Sets the netlabel socket state on sk from parent
  */
 static int apparmor_socket_getpeersec_dgram(struct socket *sock,
-					    struct sk_buff *skb, u32 *secid)
+					    struct sk_buff *skb,
+					    struct lsm_export *l)
 
 {
 	/* TODO: requires secid support */

diff --git a/security/security.c b/security/security.c
index 3a766755b722..2f1355d10e0d 100644
--- a/security/security.c
+++ b/security/security.c

@@ -2145,10 +2145,17 @@ int security_socket_getpeersec_stream(struct socket *sock, char __user *optval,
 				optval, optlen, len);
 }
 
-int security_socket_getpeersec_dgram(struct socket *sock, struct sk_buff *skb, u32 *secid)
+int security_socket_getpeersec_dgram(struct socket *sock, struct sk_buff *skb,
+				     u32 *secid)
 {
-	return call_int_hook(socket_getpeersec_dgram, -ENOPROTOOPT, sock,
-			     skb, secid);
+	int rc;
+	struct lsm_export data = { .flags = LSM_EXPORT_NONE };
+
+	rc = call_int_hook(socket_getpeersec_dgram, -ENOPROTOOPT, sock, skb,
+			   &data);
+
+	lsm_export_secid(&data, secid);
+	return rc;
 }
 EXPORT_SYMBOL(security_socket_getpeersec_dgram);

diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c
index b88a51b6ca41..9db12f6b1221 100644
--- a/security/selinux/hooks.c
+++ b/security/selinux/hooks.c

@@ -4949,7 +4949,9 @@ static int selinux_socket_getpeersec_stream(struct socket *sock,
 	return err;
 }
 
-static int selinux_socket_getpeersec_dgram(struct socket *sock, struct sk_buff *skb, u32 *secid)
+static int selinux_socket_getpeersec_dgram(struct socket *sock,
+					   struct sk_buff *skb,
+					   struct lsm_export *l)
 {
 	u32 peer_secid = SECSID_NULL;
 	u16 family;

@@ -4971,7 +4973,7 @@ static int selinux_socket_getpeersec_dgram(struct socket *sock, struct sk_buff *
 		selinux_skb_peerlbl_sid(skb, family, &peer_secid);
 
 out:
-	*secid = peer_secid;
+	selinux_export_secid(l, peer_secid);
 	if (peer_secid == SECSID_NULL)
 		return -EINVAL;
 	return 0;

diff --git a/security/smack/smack_lsm.c b/security/smack/smack_lsm.c
index 3b77a0324c3d..3e3724bbd6ea 100644
--- a/security/smack/smack_lsm.c
+++ b/security/smack/smack_lsm.c

@@ -3973,7 +3973,8 @@ static int smack_socket_getpeersec_stream(struct socket *sock,
  * Sets the netlabel socket state on sk from parent
  */
 static int smack_socket_getpeersec_dgram(struct socket *sock,
-					 struct sk_buff *skb, u32 *secid)
+					 struct sk_buff *skb,
+					 struct lsm_export *l)
 
 {
 	struct netlbl_lsm_secattr secattr;

@@ -4024,7 +4025,7 @@ static int smack_socket_getpeersec_dgram(struct socket *sock,
 #endif
 		break;
 	}
-	*secid = s;
+	smack_export_secid(l, s);
 	if (s == 0)
 		return -EINVAL;
 	return 0;

-- 
2.19.1

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help