Thread (22 messages) 22 messages, 4 authors, 2019-03-05

Re: [PATCH v4 1/2] LSM: SafeSetID: gate setgid transitions

From: Micah Morton <mortonm@chromium.org>
Date: 2019-03-05 15:47:12

Yeah, sorry I actually fixed that in the last patch, but probably was
hard to follow since I haven't been starting new threads like you
said. Will do that from now on.

On Mon, Mar 4, 2019 at 7:30 PM James Morris [off-list ref] wrote:
On Mon, 4 Mar 2019, Micah Morton wrote:
quoted
quoted
+       case LSM_SETGID_RE:
+                break;
+       case LSM_SETGID_ID:
+                break;
+       case LSM_SETGID_RES:
+                break;
+       case LSM_SETGID_FS:
+                break;
+
These should be collapsed into multiple case statements with one break.

Also, please start a new thread when you post a new version of the
patchset, and include all of the series in each version.


--
James Morris
[off-list ref]
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help