On Tue, 12 Feb 2019 at 11:23, Andy Shevchenko [off-list ref] wrote:

On Tue, Feb 12, 2019 at 12:21 PM Andy Shevchenko
[off-list ref] wrote:

quoted

On Tue, Feb 12, 2019 at 12:15 PM Anders Roxell [off-list ref] wrote:

quoted

Commit a893ea15d764 ("tpm: move tpm_chip definition to
include/linux/tpm.h") introduced a build error when both ima and efi is
enabled. What happens is that both headers (ima.h and efi.h) defines the
same 'NONE' constant, and it broke when they started getting included
from the same file.

quoted

We only need one of the two patches applied.

I would argue that we need two patches applied. Namespace is a hidden
issue in the code.

This patch looks good to me, FWIW,
Reviewed-by: Andy Shevchenko <redacted>

Oh, did you change ABI? So, I have to say that enum changes are okay,
but ABI, if any, are not.

urgh, thank you for the review. It looks like I changed a bit too much
in ima_parse_rule() =/
I'll send send out a v2 shortly.

Cheers,
Anders