On Fri, Feb 08, 2019 at 04:21:02PM -0500, Stefan Berger wrote:

On 1/18/19 10:00 AM, Jarkko Sakkinen wrote:

quoted

On Fri, Jan 11, 2019 at 08:28:00PM +0000, Safford, David (GE Global Research) wrote:

quoted

You might mention that this is an important feature, as on at least some
systems, ppi function 23 is the only way to enable/disable PCR banks.

I have tested this patch set on my HP Spectre laptop, and I am finally
able to turn the sha-1 bank on and off. Much appreciated!

Tested-by: David Safford <redacted>

Great thanks David.

While we are at it and for the grand finale of the day :-)

+All you people, keep yourself alive!
+Keep yourself alive!
+Keep yourself alive!
+C'mon, give me your reviewed's
+to keep me satisfied!
+Give me your signed-off's                       (1)
+to keep me satisfied!
+Keep yourself alive!
+A few test-by's will keep me satisfied!
+Keep yourself alive!
+Check-in!                                                (2)
+
+[In the style of Queen]


Jarrko, do (1) and (2) to keep me satisfied :-)

I still think that in 5/5 branching could be better but is not a biggie
for me (does not make the implementation as whole any kind of mess) and
since it is now peer tested I rather would not modify it right now.

Applied to master and next!

/Jarkko