Thread (7 messages) 7 messages, 2 authors, 2019-02-08

Re: [PATCH v3 2/2] tpm/tpm_i2c_atmel: Return -E2BIG when the transfer is incomplete

From: Stefan Berger <stefanb@linux.ibm.com>
Date: 2019-02-08 16:48:14
Also in: linux-integrity, lkml, stable

On 2/8/19 11:30 AM, Jarkko Sakkinen wrote:
quoted hunk ↗ jump to hunk
Return -E2BIG when the transfer is incomplete. The upper layer does
not retry, so not doing that is incorrect behaviour.

Cc: stable@vger.kernel.org
Fixes: a2871c62e186 ("tpm: Add support for Atmel I2C TPMs")
Signed-off-by: Jarkko Sakkinen <redacted>
---
  drivers/char/tpm/tpm_i2c_atmel.c | 4 ++++
  1 file changed, 4 insertions(+)
diff --git a/drivers/char/tpm/tpm_i2c_atmel.c b/drivers/char/tpm/tpm_i2c_atmel.c
index aa11c8a1df5e..8a7e80923091 100644
--- a/drivers/char/tpm/tpm_i2c_atmel.c
+++ b/drivers/char/tpm/tpm_i2c_atmel.c
@@ -69,6 +69,10 @@ static int i2c_atmel_send(struct tpm_chip *chip, u8 *buf, size_t len)
  	if (status < 0)
  		return status;

+	/* The upper layer does not support incomplete sends. */
+	if (status != len)
+		return -E2BIG;
+
  	return 0;
  }
Reviewed-by: Stefan Berger <stefanb@linux.ibm.com>

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help