Thread (42 messages) flat view 42 messages, 4 authors, 2019-02-08

Re: [PATCH v11 00/16] Remove nested TPM operations

From: Stefan Berger <stefanb@linux.ibm.com>
Date: 2019-02-08 12:05:35
Also in: linux-integrity, lkml

On 2/8/19 6:14 AM, Jarkko Sakkinen wrote:
On Thu, Feb 07, 2019 at 08:51:15PM -0500, Stefan Berger wrote:
quoted
quoted
quoted
+    rc = 0;
       if (chip->flags & TPM_CHIP_FLAG_IRQ)
           goto out_recv;
What why?
This fix seems to only be necessary when bisecting. You may want to apply
it!
I don't want to apply it because I don't understand why it would
be needed. Can you give a short explanation?

See my comment on [PATCH v11 08/16]. It needs to be added in that patch 
since otherwise rc holds a non-zero value on function exit, which is 
wrong at that point.

/Jarkko
  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help