Thread (10 messages) 10 messages, 4 authors, 2019-02-05

Re: [PATCH v2] tpm/st33zp24: Fix the name collisions in tpm_st33zp24_spi and tpm_i2c_infineon

From: James Bottomley <James.Bottomley@HansenPartnership.com>
Date: 2019-02-05 19:40:27
Also in: linux-integrity, lkml, stable

On Mon, 2019-02-04 at 15:37 +0200, Jarkko Sakkinen wrote:
quoted hunk ↗ jump to hunk
diff --git a/drivers/char/tpm/tpm_i2c_infineon.c
b/drivers/char/tpm/tpm_i2c_infineon.c
index 9086edc9066b..b9d5a1dda8d2 100644
--- a/drivers/char/tpm/tpm_i2c_infineon.c
+++ b/drivers/char/tpm/tpm_i2c_infineon.c
[...]
quoted hunk ↗ jump to hunk
@@ -527,8 +528,8 @@ static int tpm_tis_i2c_send(struct tpm_chip
*chip, u8 *buf, size_t len)
 	u8 retries = 0;
 	u8 sts = TPM_STS_GO;
 
-	if (len > TPM_BUFSIZE)
-		return -E2BIG;	/* command is too long for our
tpm, sorry */
+	if (len > TPM_I2C_INFINEON_BUFSIZE)
TPM_I2C_INFINEON_MAX_BUFSIZE, surely, otherwise it won't compile ...
the kbuild robot just spotted this as well.

James
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help