Re: [PATCH v4 3/5] LSM: add new hook for kernfs node initialization

Hi Ondrej,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on driver-core/driver-core-testing]
[also build test ERROR on v5.0-rc4 next-20190205]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Ondrej-Mosnacek/Allow-initializing-the-kernfs-node-s-secctx-based-on-its-parent/20190205-171434
config: sparc-defconfig (attached as .config)
compiler: sparc-linux-gcc (GCC) 8.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=8.2.0 make.cross ARCH=sparc 

All errors (new ones prefixed by >>):

   In file included from include/net/scm.h:8,
                    from include/linux/netlink.h:9,
                    from include/uapi/linux/neighbour.h:6,
                    from include/linux/netdevice.h:50,
                    from include/linux/etherdevice.h:26,
                    from arch/sparc/kernel/idprom.c:13:
   include/linux/security.h:796:1: error: expected identifier or '(' before '{' token
    {
    ^

quoted

include/linux/security.h:792:19: error: 'security_kernfs_init_security' declared 'static' but never defined [-Werror=unused-function]

    static inline int security_kernfs_init_security(
                      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   cc1: all warnings being treated as errors

vim +792 include/linux/security.h

   791	
 > 792	static inline int security_kernfs_init_security(
   793			const struct qstr *qstr, const struct iattr *dir_iattr,
   794			struct simple_xattrs *dir_secattr, const struct iattr *iattr,
   795			struct simple_xattrs *secattr);
 > 796	{
   797		return 0;
   798	}
   799	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation