On Wed, Jan 30, 2019 at 08:52:40AM +0100, Roberto Sassu wrote:

On 1/29/2019 8:29 PM, Jarkko Sakkinen wrote:

quoted

On Thu, Jan 24, 2019 at 04:49:04PM +0100, Roberto Sassu wrote:

quoted

+	chip->allocated_banks = kcalloc(1, sizeof(*chip->allocated_banks),
+					GFP_KERNEL);
+	if (!chip->allocated_banks) {
+		rc = -ENOMEM;
+		goto out;
+	}
+
+	chip->allocated_banks[0] = TPM2_ALG_SHA1;
+	chip->nr_allocated_banks = 1;

Everything else looks nice in this patch except this.

You always branch for TPM 1.2, and it will always have just SHA1. This
is unnecessary.

Without this, users of the TPM driver have to call tpm_is_tpm2() first,
while instead they can look directly at chip->allocated_banks.

I realized this after going through the whole patch set and sleeping
one night :-) You can keep it. I was mistaken here.

/Jarkko