Re: [PATCH 14/17] mm: Make hibernate handle unmapped pages

On Thu 2019-01-17 23:48:30, Edgecombe, Rick P wrote:

On Fri, 2019-01-18 at 00:41 +0100, Pavel Machek wrote:

quoted

Hi!

quoted

quoted

quoted

For architectures with CONFIG_ARCH_HAS_SET_ALIAS, pages can be unmapped
briefly on the directmap, even when CONFIG_DEBUG_PAGEALLOC is not
configured.
So this changes kernel_map_pages and kernel_page_present to be defined
when
CONFIG_ARCH_HAS_SET_ALIAS is defined as well. It also changes places
(page_alloc.c) where those functions are assumed to only be implemented
when
CONFIG_DEBUG_PAGEALLOC is defined.

Which architectures are that?

Should this be merged to the patch where HAS_SET_ALIAS is introduced? We
don't want broken hibernation in between....

Thanks for taking a look. It was added for x86 for patch 13 in this patchset
and
there was interest expressed for adding for arm64. If you didn't get the
whole
set and want to see let me know and I can send it.

I googled in in the meantime.

Anyway, if something is broken between patch 13 and 14, then they
should be same patch.

Great. It should be ok because the new functions are not used anywhere until
after this patch.

Ok, that makes sense.

Acked-by: Pavel Machek <redacted>
									Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html