Thread (88 messages) 88 messages, 7 authors, 2019-02-12

Re: [PATCH v5 2/2] LSM: add SafeSetID module that gates setid calls

From: James Morris <jmorris@namei.org>
Date: 2019-01-28 20:10:03

On Tue, 29 Jan 2019, Kees Cook wrote:
On Tue, Jan 29, 2019 at 8:47 AM Micah Morton [off-list ref] wrote:
quoted
I'm getting the following crash when booting after compiling a kernel
with this LSM enabled, so I'll have to figure out what is going on.
All the "core" functionality of this LSM has been tested thoroughly
(we're already using this LSM on ChromeOS), but looks like there's
some debugging of the initialization that still needs to be done.

+DEFINE_LSM(safesetid_security_init) = {
+       .init = safesetid_security_init,
+};

I think this is from not having:

.name = "safesetid",

I missed that in the review, sorry!
Weird, I booted my system with safesetid stacked and it seemed to work.

-- 
James Morris
[off-list ref]
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help