Thread (9 messages) 9 messages, 2 authors, 2018-10-24

RE: [PATCH] tpm: tpm_try_transmit() refactor error flow.

From: Winkler, Tomas <hidden>
Date: 2018-10-18 06:06:30
Also in: linux-integrity, lkml, stable

-----Original Message-----
From: Jarkko Sakkinen [mailto:jarkko.sakkinen@linux.intel.com]
Sent: Thursday, October 18, 2018 03:15
To: Winkler, Tomas <redacted>
Cc: Jarkko Sakkinen <redacted>; Jason Gunthorpe
[off-list ref]; Nayna Jain [off-list ref]; Usyskin,
Alexander [off-list ref]; Struk, Tadeusz
[off-list ref]; linux-integrity@vger.kernel.org; linux-security-
module@vger.kernel.org; linux-kernel@vger.kernel.org;
stable@vger.kernel.org
Subject: Re: [PATCH] tpm: tpm_try_transmit() refactor error flow.

On Tue, 16 Oct 2018, Tomas Winkler wrote:
quoted
First, rename out_no_locality to out_locality for bailing out on both
tpm_cmd_ready() and tpm_request_locality() failure.
This is unnecessary change and technically it is not a rename: the commit
message text and the code change do not match. Rename is just a rename
(i.e. change a variable name foo to bar).
I'm renaming the label because it doesn't match the code flow anymore,
I can change the commit message, but you please review the code.
Tomas



Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help