possible deadlock in start_this_handle

From
Jan Kara <jack@suse.cz>
Date
2018-09-07 09:38:19
Also in
linux-ext4, lkml
On Fri 07-09-18 01:38:03, syzbot wrote:
Hello,

syzbot found the following crash on:

HEAD commit:    ca16eb342ebe Merge tag 'for-linus-20180906' of git://git.k..
git tree:       upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=129e80ae400000
kernel config:  https://syzkaller.appspot.com/x/.config?x=6c9564cd177daf0c
dashboard link: https://syzkaller.appspot.com/bug?extid=fe49aec75e221f9b093e
compiler:       gcc (GCC) 8.0.1 20180413 (experimental)

Unfortunately, I don't have any reproducer for this crash yet.

IMPORTANT: if you fix the bug, please add the following tag to the commit:
Reported-by: syzbot+fe49aec75e221f9b093e at syzkaller.appspotmail.com
So this looks like a false positive due to Michal's memalloc_nofs_save()
work and lockdep not being clever enough. And it actually nicely shows how
Michal's work prevents real deadlock possibilities.
======================================================
WARNING: possible circular locking dependency detected
4.19.0-rc2+ #2 Not tainted
------------------------------------------------------
kswapd0/1430 is trying to acquire lock:
0000000085a9412e (jbd2_handle){++++}, at: start_this_handle+0x589/0x1260
fs/jbd2/transaction.c:383

but task is already holding lock:
00000000af99a839 (fs_reclaim){+.+.}, at: __page_frag_cache_refill
mm/page_alloc.c:4476 [inline]
00000000af99a839 (fs_reclaim){+.+.}, at: __fs_reclaim_acquire+0x0/0x30
mm/page_alloc.c:4505
So lockdep is complaining about kswapd starting a transaction during fs
reclaim. It should be OK to do so so let's see why lockdep thinks starting
a transaction in fs reclaim is not good.
the existing dependency chain (in reverse order) is:

-> #2 (fs_reclaim){+.+.}:
       __fs_reclaim_acquire mm/page_alloc.c:3728 [inline]
       fs_reclaim_acquire.part.98+0x24/0x30 mm/page_alloc.c:3739
       fs_reclaim_acquire+0x14/0x20 mm/page_alloc.c:3740
       slab_pre_alloc_hook mm/slab.h:418 [inline]
       slab_alloc mm/slab.c:3378 [inline]
       kmem_cache_alloc_trace+0x2d/0x730 mm/slab.c:3618
Here smack is doing GFP_KERNEL allocation. In this case it gets called from
shmfs which is OK with doing fs reclaim... <see below>
quoted hunk
       kmalloc include/linux/slab.h:513 [inline]
       kzalloc include/linux/slab.h:707 [inline]
       smk_fetch.part.24+0x5a/0xf0 security/smack/smack_lsm.c:273
       smk_fetch security/smack/smack_lsm.c:3548 [inline]
       smack_d_instantiate+0x946/0xea0 security/smack/smack_lsm.c:3502
       security_d_instantiate+0x5c/0xf0 security/security.c:1287
       d_instantiate+0x5e/0xa0 fs/dcache.c:1870
       shmem_mknod+0x189/0x1f0 mm/shmem.c:2812
       vfs_mknod+0x447/0x800 fs/namei.c:3719
       handle_create+0x1ff/0x7c0 drivers/base/devtmpfs.c:211
       handle drivers/base/devtmpfs.c:374 [inline]
       devtmpfsd+0x27f/0x4c0 drivers/base/devtmpfs.c:400
       kthread+0x35a/0x420 kernel/kthread.c:246
       ret_from_fork+0x3a/0x50 arch/x86/entry/entry_64.S:413

-> #1 (&isp->smk_lock){+.+.}:
       __mutex_lock_common kernel/locking/mutex.c:925 [inline]
       __mutex_lock+0x171/0x1700 kernel/locking/mutex.c:1073
       mutex_lock_nested+0x16/0x20 kernel/locking/mutex.c:1088
       smack_d_instantiate+0x130/0xea0 security/smack/smack_lsm.c:3369
       security_d_instantiate+0x5c/0xf0 security/security.c:1287
... while here the same function gets called from ext4 which will have
PF_MEMALLOC_NOFS set so fs reclaim won't happen. Lockdep transfers the
locking dependency through isp->smk_lock as it is not clever enough to know
that this lock in shmfs case is different from this lock in ext4 case -
they are in the same locking class.

So what Smack needs to do to prevent these false positives is to set
locking class of its smk_lock to be different for different filesystem
types. We do the same for other inode-related locks in fs/inode.c:
inode_init_always() - see the lockdep_set_class calls there - so Smack
needs to do something similar.
       d_instantiate_new+0x7e/0x160 fs/dcache.c:1889
       ext4_add_nondir+0x81/0x90 fs/ext4/namei.c:2415
       ext4_symlink+0x761/0x1170 fs/ext4/namei.c:3162
       vfs_symlink+0x37a/0x5d0 fs/namei.c:4127
       do_symlinkat+0x242/0x2d0 fs/namei.c:4154
       __do_sys_symlink fs/namei.c:4173 [inline]
       __se_sys_symlink fs/namei.c:4171 [inline]
       __x64_sys_symlink+0x59/0x80 fs/namei.c:4171
       do_syscall_64+0x1b9/0x820 arch/x86/entry/common.c:290
       entry_SYSCALL_64_after_hwframe+0x49/0xbe
								Honza
-- 
Jan Kara [off-list ref]
SUSE Labs, CR
Thread (1 message) 1 message, 1 author, last reply 2018-09-07
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help