[PATCH resend] uapi/linux/keyctl.h: don't use C++ reserved keyword as a struct member name
From: gregkh@linuxfoundation.org (Greg KH)
Date: 2018-08-29 02:42:29
Also in:
keyrings, lkml, stable
From: gregkh@linuxfoundation.org (Greg KH)
Date: 2018-08-29 02:42:29
Also in:
keyrings, lkml, stable
On Tue, Aug 28, 2018 at 04:34:04PM -0700, Randy Dunlap wrote:
From: Randy Dunlap <redacted> Since this header is in "include/uapi/linux/", apparently people want to use it in userspace programs -- even in C++ ones. However, the header uses a C++ reserved keyword ("private"), so change that to "dh_private" instead to allow the header file to be used in C++ userspace. Fixes https://bugzilla.kernel.org/show_bug.cgi?id=191051 Fixes: ddbb41148724 ("KEYS: Add KEYCTL_DH_COMPUTE command") Signed-off-by: Randy Dunlap <redacted> Cc: David Howells <dhowells@redhat.com> Cc: James Morris <jmorris@namei.org> Cc: "Serge E. Hallyn" <serge@hallyn.com> Cc: keyrings at vger.kernel.org Cc: linux-security-module at vger.kernel.org Cc: Mat Martineau <redacted> Cc: stable at vger.kernel.org --- include/uapi/linux/keyctl.h | 2 +- security/keys/dh.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)--- lnx-416.orig/include/uapi/linux/keyctl.h +++ lnx-416/include/uapi/linux/keyctl.h@@ -65,7 +65,7 @@ /* keyctl structures */ struct keyctl_dh_params { - __s32 private; + __s32 dh_private;
Ick ick ick, why not just put the C "namespace" on all uapi files if you are including them from c++ code? I'm sure this isn't the only problem that has this problem, right? This is valid C, no need to start worrying about C++ reserved names. thanks, greg "'struct class' is your friend" k-h