Thread (14 messages) 14 messages, 3 authors, 2018-06-05

[PATCH] Smack: Fix memory leak in smack_inode_getsecctx

From: tj@kernel.org (Tejun Heo)
Date: 2018-06-04 21:27:09
Also in: linux-nfs, lkml

On Mon, Jun 04, 2018 at 02:01:34PM -0700, Casey Schaufler wrote:
On 6/1/2018 10:45 AM, Casey Schaufler wrote:
quoted
Fix memory leak in smack_inode_getsecctx

The implementation of smack_inode_getsecctx() made
incorrect assumptions about how Smack presents a security
context. Smack does not need to allocate memory to support
security contexts, so "releasing" a Smack context is a no-op.
The code made an unnecessary copy and returned that as a
context, which was never freed. The revised implementation
returns the context correctly.

Signed-off-by: Casey Schaufler <casey@schaufler-ca.com>
Tejun, does this pass your tests?
Oh, I'm not the one who reported.  Chandan?

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help