On Tue, Mar 06, 2018 at 11:34:50AM +0000, Winkler, Tomas wrote:

quoted

On Tue, 2018-03-06 at 11:30 +0200, Tomas Winkler wrote:

quoted

Factor out get random implementation from tpm-interface.c into
tpm1_get_random function in tpm1-cmd.c.
No functional changes.

Signed-off-by: Tomas Winkler <redacted>

While you are doing this, please make it use tpm_buf so tha we get stuff out
of that nasty union. Using "helper" structs is still fine, just move it right
before the function implementation out of tpm.h (there are examples of this
tpm2-cmd.c).

Sure, but not while moving code, this is dangerous. Should be done after code is moved.

Makes sense have use two steps here.

/Jarkko
--
To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html