On Mon, Mar 05, 2018 at 03:03:20PM +0200, Jarkko Sakkinen wrote:

quoted

On Sun, Mar 04, 2018 at 02:12:05PM +0200, Tomas Winkler wrote:

quoted

This suppresses sparse warning
drivers/char/tpm/tpm_crb.c:558:18: warning: cast to restricted
__le64

Signed-off-by: Tomas Winkler <redacted>
---
 drivers/char/tpm/tpm_crb.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

The guideline is that you should describe what is wrong rather than
copy-paste the sparse message.

Jason, didn't yo give the feedback to some patch 1-2 years ago that instead
of copy-pasting parse error one should write a clear commit msg or is this
OK?

I think you are reading wrongly the rule,  the title explains the issue and in addition 
I'm adding exact sparse warning. this is usually required. 
What is wrong is putting something like 'Fix sparse error' or "Fix warning' into patch subject. 
So the imperative here is 'adding annotation' and not a 'fixing a sparse message'.

Thanks
Tomas

--
To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html