[PATCH] security: Export few symbols referred by other modules

On Wed, Dec 06, 2017 at 08:45:01PM +0530, Hareesh Gundu wrote:

On 12/5/2017 6:51 PM, Tetsuo Handa wrote:

quoted

James Morris wrote:

quoted

On Tue, 5 Dec 2017, Hareesh Gundu wrote:

quoted

Export mmap_min_addr and security_mmap_addr() to allow
kernel modules to use them.

Signed-off-by: Hareesh Gundu <redacted>

Can other folks comment whether this should be EXPORT_SYMBOL or
EXPORT_SYMBOL_GPL ?

What do you think?

quoted

quoted

I'm not sure whether this should be EXPORT_SYMBOL or EXPORT_SYMBOL_GPL, as
this hook was added in 2009, well after EXPORT_SYMBOL_GPL came into being.

Most of the LSM hooks are marked EXPORT_SYMBOL because they were part of
an existing interface when EXPORT_SYMBOL_GPL was introduced, IIRC.

What do folks think?

?That's right, This change is for outside kernel tree modules.

Then it should not be exported at all, sorry.

Please work to get your code merged into the kernel tree and then it can
be exported properly for it.  Odds are, you don't really need these
symbols, as {hint}, no one else does...

sorry,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html