Thread (2 messages) 2 messages, 2 authors, 2017-10-16

[PATCH][V2] selinux: remove extraneous initialization of slots_used and max_chain_len

From: paul@paul-moore.com (Paul Moore)
Date: 2017-10-16 22:42:24
Also in: kernel-janitors, lkml, selinux

On Sat, Oct 14, 2017 at 11:38 AM, Colin King [off-list ref] wrote:
From: Colin Ian King <redacted>

Variables slots_used and max_chain_len are being initialized to zero
twice. Remove the second set of initializations in the for loop.
Cleans up the clang warnings:

Value stored to 'slots_used' is never read
Value stored to 'max_chain_len' is never read

Signed-off-by: Colin Ian King <redacted>
---
 security/selinux/ss/hashtab.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Also merged, thanks.
quoted hunk ↗ jump to hunk
diff --git a/security/selinux/ss/hashtab.c b/security/selinux/ss/hashtab.c
index bef7577d1270..e0443f4afea5 100644
--- a/security/selinux/ss/hashtab.c
+++ b/security/selinux/ss/hashtab.c
@@ -150,7 +150,7 @@ void hashtab_stat(struct hashtab *h, struct hashtab_info *info)

        slots_used = 0;
        max_chain_len = 0;
-       for (slots_used = max_chain_len = i = 0; i < h->size; i++) {
+       for (i = 0; i < h->size; i++) {
                cur = h->htable[i];
                if (cur) {
                        slots_used++;
--
2.14.1
-- 
paul moore
www.paul-moore.com
--
To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help