[PATCH v5 1/4] ima: always measure and audit files in policy
flat view
From: Christoph Hellwig <hch@lst.de>
Date: 2017-08-11 10:18:11
Also in:
linux-fsdevel
+ i_version = file_inode(file)->i_version;
This probably wants a comment that i_version might be unreliable unless the file system supports the change attribute.
+ result = (!buf) ? ima_calc_file_hash(file, &hash.hdr) : + ima_calc_buffer_hash(buf, size, &hash.hdr);
Please write this like proper C code: if (buf) result = ima_calc_buffer_hash(buf, size, &hash.hdr); else result = ima_calc_file_hash(file, &hash.hdr);
quoted hunk ↗ jump to hunk
+++ b/security/integrity/ima/ima_crypto.c@@ -441,6 +441,16 @@ int ima_calc_file_hash(struct file *file, struct ima_digest_data *hash) loff_t i_size; int rc; + /* + * O_DIRECT not supported for buffered read. For consistency, + * don't support O_DIRECT on DAX either. + */
I can't parse this - O_DIRECT is the opposite of a buffered I/O, including reads.
+ if ((rc == 0) && (action & IMA_APPRAISE_SUBMASK))
no need for the first set of inner braces. -- To unsubscribe from this list: send the line "unsubscribe linux-security-module" in the body of a message to majordomo at vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html