Thread (19 messages) 19 messages, 4 authors, 2017-07-10

[PATCH 3/4] ima: use existing read file operation method to calculate file hash

From: hch@lst.de (Christoph Hellwig)
Date: 2017-06-13 14:22:10
Also in: linux-fsdevel

On Tue, Jun 13, 2017 at 10:17:45AM -0400, Mimi Zohar wrote:
Calling ->read directly is intentional. ?Commit C0430e49b6e7c "ima:
introduce ima_kernel_read()" replaced the call to kernel_read with
ima_kernel_read(), the non-security checking version of kernel_read().
?Subsequently, commit e3c4abbfa97e "integrity: define a new function
integrity_read_file()" renamed ima_read_file() to
integrity_read_file().
Again, the point is you should not call ->read for in-kernel reads.
Both NFS and OCFS define their own specific read_iter(),
nfs_file_read() and ocfs2_file_read_iter() respectively. ?As these
file systems have not yet been converted to use ->read_integrity, the
xfstests fail.
So they will need to be converted.  The xfstests will not just fail,
it will deadlock the calling process with this code.
--
To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help