Thread (10 messages) 10 messages, 3 authors, 2017-05-25

[PATCH] tpm: vtpm_proxy: Do not run tpm2_shutdown

From: Jason Gunthorpe <hidden>
Date: 2017-05-25 21:00:57
Also in: lkml

On Thu, May 25, 2017 at 04:54:01PM -0400, Stefan Berger wrote:
This particular command will never reach anyone listening on the proxy's
file descriptor since the tear-down only begins when the front- and backend
are closed.
The logging happens somewhere else than where the error occurs. What is the
best way to suppress the logging? Remove it entirely  -- probably not.
Return a special error code that doesn't get logged?
Error code would be my choice.
that indicates this condition? It's not clear to me. Why not just
prevent the command from being sent if it will never reach its
intended destination
There are many cases where the vtpm shutdown can race with something
else, if the logging for this is bothersome it should be fixed
directly.

Adding strange special case flags is confusing as to the purpose - eg
your commit message didn't even say this is only about fixing some
noisy logging.

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help