Thread (1 message) 1 message, 1 author, 2017-03-29

[PATCH 24/46] selinux: Return directly after a failed kzalloc() in cat_read()

From: paul@paul-moore.com (Paul Moore)
Date: 2017-03-29 13:55:57
Also in: kernel-janitors, lkml, selinux

On Sun, Jan 15, 2017 at 10:24 AM, SF Markus Elfring
[off-list ref] wrote:
From: Markus Elfring <redacted>
Date: Sat, 14 Jan 2017 21:20:43 +0100

Return directly after a call of the function "kzalloc" failed
at the beginning.

Signed-off-by: Markus Elfring <redacted>
---
 security/selinux/ss/policydb.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
Merged, thanks.
quoted hunk
diff --git a/security/selinux/ss/policydb.c b/security/selinux/ss/policydb.c
index 5101592ae172..eb898dcbe502 100644
--- a/security/selinux/ss/policydb.c
+++ b/security/selinux/ss/policydb.c
@@ -1635,10 +1635,9 @@ static int cat_read(struct policydb *p, struct hashtab *h, void *fp)
        __le32 buf[3];
        u32 len;

-       rc = -ENOMEM;
        catdatum = kzalloc(sizeof(*catdatum), GFP_ATOMIC);
        if (!catdatum)
-               goto bad;
+               return -ENOMEM;

        rc = next_entry(buf, fp, sizeof buf);
        if (rc)
--
2.11.0


-- 
paul moore
www.paul-moore.com
--
To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help