Re: [PATCH] firmware_loader: export sysctl registration
From: Randy Dunlap <hidden>
Date: 2021-11-30 23:00:57
Also in:
linux-fsdevel, lkml
On 11/30/21 08:45, Luis Chamberlain wrote:
The firmware loader fallback sysctl table is always built-in, but when FW_LOADER=m the build will fail. We need to export the sysctl registration and de-registration. Use the private symbol namespace so that only the firmware loader uses these calls. Reported-by: Randy Dunlap <redacted> Fixes: firmware_loader: move firmware sysctl to its own files Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
Acked-by: Randy Dunlap <redacted> # build-tested Thanks.
quoted hunk ↗ jump to hunk
--- drivers/base/firmware_loader/fallback_table.c | 2 ++ 1 file changed, 2 insertions(+)diff --git a/drivers/base/firmware_loader/fallback_table.c b/drivers/base/firmware_loader/fallback_table.c index 51751c46cdcf..255823887c70 100644 --- a/drivers/base/firmware_loader/fallback_table.c +++ b/drivers/base/firmware_loader/fallback_table.c@@ -56,10 +56,12 @@ int register_firmware_config_sysctl(void) return -ENOMEM; return 0; } +EXPORT_SYMBOL_NS_GPL(register_firmware_config_sysctl, FIRMWARE_LOADER_PRIVATE); void unregister_firmware_config_sysctl(void) { unregister_sysctl_table(firmware_config_sysct_table_header); firmware_config_sysct_table_header = NULL; } +EXPORT_SYMBOL_NS_GPL(unregister_firmware_config_sysctl, FIRMWARE_LOADER_PRIVATE); #endif /* CONFIG_SYSCTL */
-- ~Randy